Review rm_rf handling of FileNotFoundErrors #6044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
force-pushed
the
rm-rf-review
branch
from
7752b9b to
43cac82
Compare
blueyed
approved these changes
Oct 22, 2019
|
Should we add some more context (#5974 (comment))? |
nicoddemus
force-pushed
the
rm-rf-review
branch
from
43cac82 to
17c765b
Compare
nicoddemus
force-pushed
the
rm-rf-review
branch
from
17c765b to
273ab02
Compare
|
Added a comment adding more context, and also rebased on |
nicoddemus
force-pushed
the
rm-rf-review
branch
from
273ab02 to
ba4b8c8
Compare
nicoddemus
added
the
needs backport
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Oct 23, 2019
Review rm_rf handling of FileNotFoundErrors Conflicts: src/_pytest/pathlib.py testing/test_tmpdir.py
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Oct 23, 2019
Review rm_rf handling of FileNotFoundErrors Conflicts: src/_pytest/pathlib.py testing/test_tmpdir.py
nicoddemus
added
backported
and removed
needs backport
bors bot
referenced
this pull request
in duckinator/bork
Oct 25, 2019
68: Update pytest to 5.2.2 r=duckinator a=pyup-bot This PR updates [pytest](https://pypi.org/project/pytest) from **5.2.1** to **5.2.2**. <details> <summary>Changelog</summary> ### 5.2.2 ``` ========================= Bug Fixes --------- - `5206 <https://github.com/pytest-dev/pytest/issues/5206>`_: Fix ``--nf`` to not forget about known nodeids with partial test selection. - `5906 <https://github.com/pytest-dev/pytest/issues/5906>`_: Fix crash with ``KeyboardInterrupt`` during ``--setup-show``. - `5946 <https://github.com/pytest-dev/pytest/issues/5946>`_: Fixed issue when parametrizing fixtures with numpy arrays (and possibly other sequence-like types). - `6044 <https://github.com/pytest-dev/pytest/issues/6044>`_: Properly ignore ``FileNotFoundError`` exceptions when trying to remove old temporary directories, for instance when multiple processes try to remove the same directory (common with ``pytest-xdist`` for example). ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Homepage: https://docs.pytest.org/en/latest/ </details> Co-authored-by: pyup-bot <[email protected]>
blueyed
reviewed
Oct 27, 2019
| "(rm_rf) unknown function {} when removing {}:\n{}: {}".format( | ||
| path, func, exctype, excvalue | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I think it should not warn on open, should it?
============== test session starts ===============
platform linux -- Python 3.7.4, pytest-4.6.7.dev6+g46aa29ea5.d20191026, py-1.8.1.dev11+g34f716fe, pluggy-0.12.0
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('…/Vcs/pytest/.hypothesis/examples')
rootdir: …/Vcs/pytest, inifile: tox.ini
plugins: hypothesis-4.23.8, forked-1.0.2, repeat-0.8.0, xdist-1.30.1.dev1+g79dd52b.d20191018
collected 7 items / 5 deselected / 2 selected
testing/test_faulthandler.py EE [100%]
===================== ERRORS =====================
______ ERROR at setup of test_timeout[True] ______
Traceback (most recent call last):
File "/usr/lib/python3.7/shutil.py", line 426, in _rmtree_safe_fd
dirfd = os.open(entry.name, os.O_RDONLY, dir_fd=topfd)
PermissionError: [Errno 13] Permission denied: '.pytest_cache'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3.7/shutil.py", line 494, in rmtree
_rmtree_safe_fd(fd, path, onerror)
File "/usr/lib/python3.7/shutil.py", line 432, in _rmtree_safe_fd
_rmtree_safe_fd(dirfd, fullname, onerror)
File "/usr/lib/python3.7/shutil.py", line 428, in _rmtree_safe_fd
onerror(os.open, fullname, sys.exc_info())
File "…/Vcs/pytest/src/_pytest/pathlib.py", line 65, in on_rm_rf_error
path, func, exctype, excvalue
pytest.PytestWarning: (rm_rf) unknown function /tmp/pytest-of-user/garbage-d7f65083-c870-4de6-8d7c-acf43dbafdf1/test_cache_failure_warns0/.pytest_cache when removing <built-in function open>:
<class 'PermissionError'>: [Errno 13] Permission denied: '.pytest_cache'
_____ ERROR at setup of test_timeout[False] ______
Traceback (most recent call last):
File "/usr/lib/python3.7/shutil.py", line 426, in _rmtree_safe_fd
dirfd = os.open(entry.name, os.O_RDONLY, dir_fd=topfd)
PermissionError: [Errno 13] Permission denied: '.pytest_cache'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3.7/shutil.py", line 494, in rmtree
_rmtree_safe_fd(fd, path, onerror)
File "/usr/lib/python3.7/shutil.py", line 432, in _rmtree_safe_fd
_rmtree_safe_fd(dirfd, fullname, onerror)
File "/usr/lib/python3.7/shutil.py", line 428, in _rmtree_safe_fd
onerror(os.open, fullname, sys.exc_info())
File "…/Vcs/pytest/src/_pytest/pathlib.py", line 65, in on_rm_rf_error
path, func, exctype, excvalue
pytest.PytestWarning: (rm_rf) unknown function /tmp/pytest-of-user/garbage-c10bc5b6-43ba-4bb0-b73d-1ab5d2bbcb1a/test_cache_failure_warns0/.pytest_cache when removing <built-in function open>:
<class 'PermissionError'>: [Errno 13] Permission denied: '.pytest_cache'
============ short test summary info =============
ERROR testing/test_faulthandler.py::test_timeout[True]
ERROR testing/test_faulthandler.py::test_timeout[False]
bors bot
referenced
this pull request
in rehandalal/therapist
Oct 29, 2019
98: Update pytest to 5.2.2 r=rehandalal a=pyup-bot This PR updates [pytest](https://pypi.org/project/pytest) from **5.2.1** to **5.2.2**. <details> <summary>Changelog</summary> ### 5.2.2 ``` ========================= Bug Fixes --------- - `5206 <https://github.com/pytest-dev/pytest/issues/5206>`_: Fix ``--nf`` to not forget about known nodeids with partial test selection. - `5906 <https://github.com/pytest-dev/pytest/issues/5906>`_: Fix crash with ``KeyboardInterrupt`` during ``--setup-show``. - `5946 <https://github.com/pytest-dev/pytest/issues/5946>`_: Fixed issue when parametrizing fixtures with numpy arrays (and possibly other sequence-like types). - `6044 <https://github.com/pytest-dev/pytest/issues/6044>`_: Properly ignore ``FileNotFoundError`` exceptions when trying to remove old temporary directories, for instance when multiple processes try to remove the same directory (common with ``pytest-xdist`` for example). ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Homepage: https://docs.pytest.org/en/latest/ </details> Co-authored-by: pyup-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improved the message when we are passed an unknown function.